Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #806

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore: update deps #806

merged 1 commit into from
Jul 31, 2024

Conversation

lzap
Copy link
Member

@lzap lzap commented Jul 31, 2024

SSIA

There are some shenanigans with recent OpenAPI changes in IB, not updating clients. After the update we got this:

lzap@dev:~/provisioning-backend$ make test
/home/lzap/go/bin/go1.21.9 test -tags=test ./...
# github.com/RHEnVision/provisioning-backend/internal/clients/http/image_builder
internal/clients/http/image_builder/client.gen.go:3631:6: CreateBlueprintResponse redeclared in this block

It looks like recent changes around blueprint (experimental subpath) broke it. I do not understand why the type is redeclared.

@ezr-ondrej
Copy link
Member

We'll need to regenerate anyway, the generator now generates nullable params.

@lzap
Copy link
Member Author

lzap commented Jul 31, 2024

We'll need to regenerate anyway, the generator now generates nullable params.

Yeah. The problem is not with prov API, it is with IB API.

@lzap
Copy link
Member Author

lzap commented Jul 31, 2024

This is the YAML that is causing the issue: https://gist.github.com/lzap/55d2144c19d85b1072b6d32cfbe9a6c9

@lzap
Copy link
Member Author

lzap commented Jul 31, 2024

Filed an issue: oapi-codegen/oapi-codegen#1713

Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lzap ! 🧡

@ezr-ondrej ezr-ondrej merged commit 2ea7392 into RHEnVision:main Jul 31, 2024
8 checks passed
@lzap lzap deleted the update-2024c branch July 31, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants