Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HMSPROV-2088): refacor notification's context message #584

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

amirfefer
Copy link
Member

@amirfefer amirfefer commented Jul 6, 2023

Currently, we send the generic reservation payload as the notification's context. some data is redundant (i.e. step titles, steps/step) others misleading (i.e. success flag), or might confuse - the provider's id (2) instead of the provider's string (aws).

We should send the minimal information that also will be beneficial,
This PR replaces the reservation's payload with the NotificationContext struct which includes the launch_id and the provider's string, both are used in email templates.

@adiabramovitch
Copy link
Member

linter issues

@amirfefer amirfefer closed this Jul 11, 2023
@amirfefer amirfefer reopened this Jul 11, 2023
@amirfefer
Copy link
Member Author

there are no linter issues, it was a timeout issue

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once per month, the linter github action is configured to delete cache which leads to linter exceeding 5 minutes limit on GHA which leads to a failure.

@lzap lzap merged commit 65a0960 into RHEnVision:main Jul 12, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants