Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f.navbar #153

Merged
merged 24 commits into from
Aug 8, 2013
Merged

f.navbar #153

merged 24 commits into from
Aug 8, 2013

Conversation

lukevers
Copy link
Member

@lukevers lukevers commented Aug 6, 2013

The branch f.navbar should be pulled in, and it fixes a lot of problems that we have been having.

This pull request does not, however, create full support for potential nodes, or implement searching. Those are all to come in the near future, but not yet.

When visible-sm was the main size that the responsive
css is/was using, it would freeze when trying to forever
resize the font to make sure it doesn't take up too much
room. Now it doesn't even check that. That caused problems
and now it does not!
Originally, we didn't have to add form-control
to the form elements to get them styled, but
with the new version of bootstrap we did. The
past commit since we've upgraded bootstrap, I
had to just temporarily put some old bootstrap
code in the CSS file. That CSS is now gone.
Layers don't actually work yet, but they will.
Also I put the message/edit/delete buttons on a second line so they
don't get in the way with long names.
Layers now sort of work, but needs to be the ability to hide some of
them. For instance, if I only want to view Active VPS nodes, it
shouldn't show all Active nodes and all VPS nodes, it should only show
Active VPS nodes.
@lukevers
Copy link
Member Author

lukevers commented Aug 7, 2013

@SashaCrofter has written up a short document outlining how we can use the layers efficiently. Until they are used efficiently, f.navbar should not be merged into master.

tilelayer, all, temp (NEW), newuser.
Temp is going to be used for the layers/filter layers.
Also I moved around a large function that should go at the bottom of
the file instead of the top because it was in the way of things. And
lastly, I added a "filter" variable at the top and an empty
`filterLayer` function that is going to be filled with code soon.
Also I'm beginning to do the ui section of the layers/filters. I feel
like filters is a better thing to call it because we'll be filtering
nodes out that don't match the criteria of your selected filters.
I need to think about the issue for a bit.
Not sure if that's what we want to do, but I'll leave it be for now.
Not hard to change.
lukevers added a commit that referenced this pull request Aug 8, 2013
@lukevers lukevers merged commit 0119f8d into master Aug 8, 2013
@lukevers lukevers deleted the f.navbar branch August 8, 2013 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

+/- buttons The top bar expands downward unnecessarily
1 participant