Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make edit book function use a single feature enum #3496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make edit book function use a single feature enum #3496

wants to merge 1 commit into from

Conversation

u9g
Copy link
Member

@u9g u9g commented Nov 7, 2024 •
edited
Loading

@u9g
Copy link
Member Author

u9g commented Nov 8, 2024

closes #3495

@u9g u9g linked an issue Nov 8, 2024 that may be closed by this pull request
Update book write/sign packet for 1.20.5+ #3495
Open
1 task
@u9g u9g marked this pull request as ready for review November 11, 2024 17:04
@u9g
Copy link
Member Author

u9g commented Nov 11, 2024

/fixlint

@rom1504bot
Copy link
Contributor

I ran npm run fix which fixed the lint errors, but I couldn't push the changes to this branch as the PR author didn't grant write permissions to the maintainers. The PR author must manually run npm run fix and push the changes.

@inforocket
Copy link

I've tested this locally and seems to work great. @u9g is there any chance for you to commit lint fixes?

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2024

/fixlint

@rom1504bot
Copy link
Contributor

I ran npm run fix which fixed the lint errors, but I couldn't push the changes to this branch as the PR author didn't grant write permissions to the maintainers. The PR author must manually run npm run fix and push the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PR Triage
Status: Needs triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update book write/sign packet for 1.20.5+
4 participants
@u9g @rom1504bot @inforocket @rom1504