Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics for used and created connections #3468

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add metrics for used and created connections #3468

wants to merge 1 commit into from

Conversation

laurenceisla
Copy link
Member

WIP

Closes #3214

@laurenceisla laurenceisla force-pushed the metrics-created-used branch from 1a9a1ed to 26f81d3 Compare May 4, 2024 00:18
@steve-chavez
Copy link
Member

New https://hackage.haskell.org/package/hasql-notifications now allows the new hasql pool

@steve-chavez
Copy link
Member

@laurenceisla What was the problem for this? IIRC there was a mismatch between the new hasql-pool and hasql-notifications? Can you point out the exact versions? Maybe I can raise this on hasql-notifications.

@laurenceisla
Copy link
Member Author

laurenceisla commented May 30, 2024 •
edited
Loading

What was the problem for this?

The libraries hasql-dynamic-statements and hasql-transaction didn't have versions supporting hasql >= 1.7, which hasql-notification used. But I think that's fixed now upstream, I'll try relaxing the version limit for those libraries and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty error message, db-pool size surpassed
2 participants
@laurenceisla @steve-chavez