Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Stored Procedures #1976

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

laurenceisla
Copy link
Member

@laurenceisla laurenceisla commented Oct 8, 2021

Resolves part of #1210. As noted in the issue, nested transactions won't be implemented

  • Identify stored procedures in the schema cache
  • Query the data from the procedure (INOUT and OUT), use steve-chavez@8ac5a11 as reference
  • Add tests
  • Optimize code
  • Modify changelog

@steve-chavez
Copy link
Member

We can fully support stored procedures transactions with the idea mentioned here.

@steve-chavez
Copy link
Member

On 9.0.0, when trying to call a procedure, we used to fail with:

{
    "hint": "To call a procedure, use CALL.",
    "details": null,
    "code": "42809",
    "message": "api.do_nothing() is a procedure"
}

Now we fail with a schema cache error:

Could not find the api.do_nothing() function in the schema cache

I think both errors are imprecise, ideally we should throw a 501 Not Implemented and mention procedures are not supported yet. Also maybe suggest moving to a function since we already wrap it with a transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants