Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Tools page #2046

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bharateshwq
Copy link
Contributor

Description

Fixes #2035

Created basic wire frame design for how the developer tools should look like while keeping in consideration the design language of policy Engine
Let me know if there are changes required for this

This in no way is the final commit that i expect to be merged there are a lot of optimization, responsiveness tasks and restructuring to be

Screenshots

image

@bharateshwq
Copy link
Contributor Author

Hey @MaxGhenis ,
I have pushed a new commit can you have a look at it

@anth-volk
Copy link
Collaborator

@bharateshwq This is looking great! Thanks for your work on it. Could you just do the following on the design:

  • Pad the titles underneath the images more on the top, perhaps to about 1rem
  • Show how this looks on tablet (769 to ~1200px) and mobile (<769px) breakpoints

I might also ask for a couple changes to the text of the header afterward

@bharateshwq
Copy link
Contributor Author

Hey @anth-volk,
I have done the necessary changes and added responsiveness to the developer-hub page

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @bharateshwq, this is looking good. There are a few changes I was hoping to request:

  • At the moment, this code places a wrapper around the API status and simulations pages. Could you remove that, including the "back" arrow? The pages themselves should actually be unchanged.
  • Could you link this page into the footer with the tag "Developer tools"?
  • Minor, but could you add padding to the right of the text within the link boxes at the mobile viewpoint? In the image below, you can see how the word "Simulations" runs into the button.
Screen Shot 2024-10-02 at 5 57 36 PM

I might also request some textual changes, but am hoping to do that at the end.

"allow": ["error", "warn", "info", "table"]
}
]
"jsx-a11y/no-static-element-interactions": "off"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this before your final commit?

@bharateshwq
Copy link
Contributor Author

Hey @anth-volk,

I'll definitely fix that. Do you prefer having the api-status route separate, or keeping it under developer-tools/api-status? Right now, it's the latter, in which case users might find it more intuitive to have a back button on the API status and simulation pages. Let me know your thoughts!

@anth-volk
Copy link
Collaborator

@bharateshwq I think the way you layered the URLs makes sense, but I also think their browser back button should be able to handle that navigation action, as I believe react-router-dom writes to history.

@bharateshwq
Copy link
Contributor Author

Yes @anth-volk, React Router does write to the history, so using the browser's back button would work for navigation. However, I'll be removing the back button from the UI. Additionally, the current(master) API status and simulation headers have different designs, which I feel may not appear consistent to the user.
How would you like me to proceed with this?

@anth-volk
Copy link
Collaborator

@bharateshwq That is a good point. Considering these are internal developer tools, I don't think it's too big of an issue, but certainly warrants opening a separate issue. I can't remember their designs well enough, but I'm guessing the API status page is more out-of-line with our current design. If you'd like to take it on after this one, we'd greatly appreciate it.

@anth-volk anth-volk self-requested a review October 4, 2024 17:09
@bharateshwq
Copy link
Contributor Author

Hey @anth-volk, I've made the updates as requested and am awaiting your feedback. Thanks!

@anth-volk
Copy link
Collaborator

@bharateshwq Thanks, I'm hoping to get to this either tonight or tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR: Review Requested
Development

Successfully merging this pull request may close these issues.

Create Developer Tools landing page
2 participants