Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qol(settings): energy saving, simplified UI, better perf #6390

Open
wants to merge 9 commits into
base: v3_openjdk
Choose a base branch
from

Conversation

Mathias-Boulay
Copy link
Contributor

@Mathias-Boulay Mathias-Boulay commented Dec 16, 2024

Why does this PR exist ?

This PR aims to make the user experience slightly better:

  • It brings a new set of default settings to take into account more (and less) powerful devices.
  • It changes a few UI elements to allow the user to focus on the action he wants the most

Notable changes

Changes in behavior

  • Resolution, ASR, vsync and sustained performance is tweaked depending on whether a device is considered "powerful"
  • The profile selector will now display a simplified profile name if no name is provided. No name is present by default for new profiles
  • A new JVM argument is now under control of the launcher. It allows to properly state the amount of cores present on the device, increasing performance slightly.

Refactors

  • seekbar increments (among other resources) have been centralised into a resource file and turned into XML settings for their respective views
  • some strings have been de-duplicated

Fixes

  • The gamepad is now able of the resolution changing on the fly
  • (Android <= Q) The notch size was not computed properly in game

Less boiling pocket heaters.
May contain a small few refactor
Setting it ourselves guarantee a better experience by default
Also refactored the use of a constant across the code
This was due to an issue that only happens within older android versions.
@Mathias-Boulay Mathias-Boulay changed the title Qol(settings): use energy saving settings for powerful devices Qol(settings): energy saving, simplified UI, better perf Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant