Fix/#227 #235
Merged
Fix/#227 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isakatty
reviewed
Apr 15, 2024
| @@ -20,6 +20,7 @@ public extension String { | |||
| let date = Date() | |||
| let formatter = DateFormatter() | |||
| formatter.dateFormat = "yyyy.MM.dd.HH.mm" | |||
| formatter.locale = Locale(identifier: "ko_KR") | |||
There was a problem hiding this comment.
이 빌드 버전을 통해서 테스트 플라이트 올라갈 때 한국 시간으로 되는거군요 !
회의때 잠깐 이야기하고 지나갔는데 바로 적용,,,, 역시 , , 👍🏻
yuhaeun-la
reviewed
Apr 15, 2024
| Button(intent: entry.configuration) { | ||
| Image(systemName: "arrow.clockwise") | ||
| } | ||
| .buttonStyle(.plain) | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
위젯이 구분되도록 컴포넌트 올려둔거라 기존구현뷰는 지우고 작업하셔도 됩니다!
| // An example configurable parameter. | ||
| @Parameter(title: "Favorite Emoji", default: "😃") | ||
| var favoriteEmoji: String | ||
| @Parameter(title: "정류장", optionsProvider: BusStopOptionProvider()) |
There was a problem hiding this comment.
BusOptionProvider() 로 사용자가 버스 번호를 동적으로 조절할 수 있게 만들어주는건가요?
There was a problem hiding this comment.
DynamicOptionsProvider 이용해서 하는거군여
There was a problem hiding this comment.
네 지원 타겟이 iOS 17.0이상이라 해당 방식을 선택했습니다
|
머지하겠습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내용
리뷰요청
관련 이슈
close #227