Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to check if pathfinder allows the mob to fly #11820

Closed
wants to merge 1 commit into from

Conversation

GliczDev
Copy link
Contributor

There's no universal way to check if mob can fly and the only shared logic between flying mobs in NMS is FlyingPathNavigation.
Not sure about the method name, but should be ok

@GliczDev GliczDev requested a review from a team as a code owner December 25, 2024 13:57
@kennytv kennytv added the type: feature Request for a new Feature. label Dec 25, 2024
@GliczDev
Copy link
Contributor Author

GliczDev commented Dec 26, 2024

ok, so I just found out that there is also FlyingMoveControl.
is the current implementation ok, or should I add Mob#canFly and check for FlyingMoveControl?

edit: also, it seems that EnderDragon doesn't use FlyingPathNavigation nor FlyingMoveControl, any thoughts?

@lynxplay
Copy link
Contributor

Yea, Phantoms and Ghasts don't use it either.
This seems like a bit of an impossible task to properly do.
This is at best gonna be an EntityTag once we have the ability to properly define custom paper tags, but for now I don't think a new API method like this makes sense given the server has many definitions for flying entities (e.g. FlyingMob vs FlyingPathNavigation vs whatever they may come up next).

Thank you anyway for the PR, does highlight that we should work towards custom tags maybe somewhat soon :)

@lynxplay lynxplay closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Request for a new Feature.
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants