Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BlockRedstoneEvent for tripwire hooks #11791

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Fix BlockRedstoneEvent for tripwire hooks #11791

merged 1 commit into from
Dec 26, 2024
+53 −9

Conversation

Lulu13022002
Copy link
Contributor

@Lulu13022002 Lulu13022002 commented Dec 23, 2024 •
edited by kennytv
Loading

Original: #9724

Closes #9714

@Lulu13022002 Lulu13022002 requested a review from a team as a code owner December 23, 2024 18:24
@Lulu13022002 Lulu13022002 linked an issue Dec 23, 2024 that may be closed by this pull request
Tripwire hook not registering properly on BlockRedstoneEvents #9714
Closed
@kennytv kennytv added the type: bug Something doesn't work as it was intended to. label Dec 23, 2024
lynxplay
lynxplay requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, just nitpicks (especially around the obfhelpers, the other is whatever)

paper-server/patches/sources/net/minecraft/world/level/block/TripWireHookBlock.java.patch Show resolved Hide resolved
paper-server/patches/sources/net/minecraft/world/level/block/TripWireHookBlock.java.patch Outdated Show resolved Hide resolved
paper-server/patches/sources/net/minecraft/world/level/block/TripWireHookBlock.java.patch Outdated Show resolved Hide resolved
paper-server/patches/sources/net/minecraft/world/level/block/TripWireHookBlock.java.patch Outdated Show resolved Hide resolved
@lynxplay lynxplay merged commit f51aa3e into PaperMC:main Dec 26, 2024
3 checks passed
@Lulu13022002 Lulu13022002 deleted the fix/redhook branch December 26, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynxplay lynxplay lynxplay approved these changes

@Machine-Maker Machine-Maker Machine-Maker approved these changes

Assignees
No one assigned
Labels
type: bug Something doesn't work as it was intended to.
Projects
Paper PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tripwire hook not registering properly on BlockRedstoneEvents
4 participants
@Lulu13022002 @Machine-Maker @lynxplay @kennytv