-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PlayerUseBowWithoutProjectileEvent #11774
base: main
Are you sure you want to change the base?
Add PlayerUseBowWithoutProjectileEvent #11774
Conversation
paper-api/src/main/java/io/papermc/paper/event/player/PlayerUseBowWithoutProjectileEvent.java
Outdated
Show resolved
Hide resolved
return item.clone(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this event is only specific to bows, I think that this should be getBowItem() or something more specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tries to draw a bow or load a crossbow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be able to find a better name I guess, but certainly not related to bows xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant bows, which applies to both crossbows/bow. But not sure, maybe leave as is then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess something like weapon item
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cant you use anything as "bow" now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just getWeapon()?
Maybe ProjectileWeaponItem, because thats the superclass of both bow and crossbow, although that's a really long name. PlayerMissingProjectileItem? (And isn't PlayerReadyArrowEvent confusing then, because its fired for crossbows and firework rockets aswell?) |
… adjust javadocs, fix using old parameter name when calling event in Player#getProjectile
#11669
(Still dont have a better name for the event)