Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM] update tensor and pipeline parallel for chatglmv2 #9204

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

DrownFish19
Copy link
Collaborator

@DrownFish19 DrownFish19 commented Sep 26, 2024

PR types

Bug fixes

PR changes

Models

Description

fix tensor parallel for chatglmv2. This is a duplicate of #9133 and #9043.

  1. output_layer中weight切分需要设置self.weight.is_distributed属性。
  2. add pipeline parallel for chatglmv2

@DrownFish19 DrownFish19 reopened this Sep 26, 2024
@DrownFish19 DrownFish19 changed the title [LLM] Fix tensor parallel for chatglmv2 [LLM] update tensor and pipeline parallel for chatglmv2 Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 132 lines in your changes missing coverage. Please review.

Project coverage is 53.00%. Comparing base (f80a051) to head (14cb0e9).

Files with missing lines Patch % Lines
paddlenlp/transformers/chatglm_v2/modeling_pp.py 21.33% 118 Missing ⚠️
paddlenlp/transformers/chatglm_v2/modeling.py 71.42% 12 Missing ⚠️
...p/experimental/transformers/chatglm_v2/modeling.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9204      +/-   ##
===========================================
- Coverage    53.02%   53.00%   -0.03%     
===========================================
  Files          656      658       +2     
  Lines       106153   106311     +158     
===========================================
+ Hits         56288    56348      +60     
- Misses       49865    49963      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI ZHUI self-requested a review September 30, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants