Fix InlineAssembly schema errors (#50)

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+### 0.4.58 (2024-08-29)
+
+- Fixed `YulFunctionDefinition.parameters` and `returnVariables`: made optional, used when empty.
+- Fixed `InlineAssembly.externalReferences[].suffix`: added `'length'` option.
+
 ### 0.4.57 (2024-07-16)
 
 - Fixed `ModifierDefinition.body`: made nullable to support Solidity 0.6.7 virtual modifiers with empty body.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "solidity-ast",
-  "version": "0.4.57",
+  "version": "0.4.58",
   "description": "Solidity AST schema and type definitions",
   "author": "Francisco Giordano <[email protected]>",
   "repository": "github:OpenZeppelin/solidity-ast",

scripts/build-schema.js

@@ -498,7 +498,7 @@ const schema = {
           isSlot: boolean,
           src: ref('SourceLocation'),
           valueSize: integer,
-          suffix: optional(literal('slot', 'offset')),
+          suffix: optional(literal('slot', 'offset', 'length')),
         })),
         flags: optional(array(literal('memory-safe'))),
       },
@@ -817,8 +817,8 @@ const schema = {
       YulFunctionDefinition: {
         body: ref('YulBlock'),
         name: string,
-        parameters: array(ref('YulTypedName')),
-        returnVariables: array(ref('YulTypedName')),
+        parameters: optional(array(ref('YulTypedName'))),
+        returnVariables: optional(array(ref('YulTypedName'))),
       },
 
       YulIdentifier: {

test/sources/asm-0.6.sol

@@ -7,6 +7,10 @@ contract Asm {
         assembly {
             let x := s_slot
             let y := s_offset
+
+            function fail() {
+                revert(0, 0)
+            }
         }
     }
 }

test/sources/asm-0.7.5.sol

@@ -0,0 +1,9 @@
+pragma solidity >=0.7.5;
+
+contract Asm {
+    function foo(bytes calldata b) external {
+        assembly {
+            let z := b.length
+        }
+    }
+}

test/sources/asm-0.7.sol

@@ -7,6 +7,10 @@ contract Asm {
         assembly {
             let x := s.slot
             let y := s.offset
+
+            function fail() {
+                revert(0, 0)
+            }
         }
     }
 }