Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(L-04): Public Exposure of pause and unpause Functions #311

Open
wants to merge 4 commits into
base: v0.1.0
Choose a base branch
from
Open

fix(L-04): Public Exposure of pause and unpause Functions #311

wants to merge 4 commits into from

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Oct 4, 2024 •
edited
Loading

Methods pause and unpause are not exposed by default now.

Resolves #314

@qalisander qalisander marked this pull request as ready for review October 4, 2024 11:29
bidzyyys
bidzyyys reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments @qalisander

contracts/src/utils/pausable.rs Show resolved Hide resolved
examples/erc721/src/lib.rs Outdated Show resolved Hide resolved
examples/erc721/src/lib.rs Outdated Show resolved Hide resolved
examples/erc20/src/lib.rs Outdated Show resolved Hide resolved
examples/erc20/src/lib.rs Outdated Show resolved Hide resolved
@bidzyyys bidzyyys linked an issue Oct 4, 2024 that may be closed by this pull request
[Audit]: L-04 Public Exposure of pause and unpause Functions #314
Open
1 task
ggonzalez94
ggonzalez94 reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Left one small comment and a questions that came to my mind as I was reviewing about the visibility of the "modifiers"

contracts/src/utils/pausable.rs Outdated Show resolved Hide resolved
contracts/src/utils/pausable.rs Outdated Show resolved Hide resolved
contracts/src/utils/pausable.rs Outdated Show resolved Hide resolved
@ggonzalez94 ggonzalez94 mentioned this pull request Oct 4, 2024
Open
ggonzalez94
ggonzalez94 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner interface, love it.

bidzyyys
bidzyyys approved these changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggonzalez94 ggonzalez94 ggonzalez94 approved these changes

@bidzyyys bidzyyys bidzyyys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Audit]: L-04 Public Exposure of pause and unpause Functions
3 participants
@qalisander @ggonzalez94 @bidzyyys