Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor functions that don't need to return a result & use Error instead of Vec<u8> #282

Open
1 task done
ggonzalez94 opened this issue Sep 12, 2024 · 0 comments
Open
1 task done

Refactor functions that don't need to return a result & use Error instead of Vec<u8> #282

ggonzalez94 opened this issue Sep 12, 2024 · 0 comments
Assignees
@ggonzalez94
Labels
effort: medium Default level of effort. priority: 1 We will do our best to deal with this. type: chore A maintenance-related change.
Milestone
Release v0.2.0

Comments

@ggonzalez94
Copy link
Collaborator

ggonzalez94 commented Sep 12, 2024 •
edited
Loading

What is the feature you would like to see?

Previously, all public methods were required to return a Result type with Vec as the error type.

  • This is now optional. Specifically, if a method is "infallible" (i.e., it cannot produce an error), it does not need to return a Result type.
  • We should use Errcombined with #[derive(SolidityError)] when the function does need to return a Result

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@ggonzalez94 ggonzalez94 added priority: 1 We will do our best to deal with this. effort: medium Default level of effort. type: chore A maintenance-related change. labels Sep 12, 2024
@ggonzalez94 ggonzalez94 self-assigned this Sep 12, 2024
@ggonzalez94 ggonzalez94 added this to the Release v0.2.0 milestone Sep 12, 2024
@ggonzalez94 ggonzalez94 changed the title Refactor functions that don't need to return a result Refactor functions that don't need to return a result & use Error instead of Vec<u8> Oct 4, 2024
@ggonzalez94 ggonzalez94 mentioned this issue Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggonzalez94 ggonzalez94

Labels
effort: medium Default level of effort. priority: 1 We will do our best to deal with this. type: chore A maintenance-related change.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
Release v0.2.0
Development

No branches or pull requests
1 participant
@ggonzalez94