Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add approval process create API + example #275

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Add approval process create API + example #275

wants to merge 8 commits into from
+222 −4

Conversation

MCarlomagno
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bcc67d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security Socket Security
Copy link

socket-security bot commented Feb 29, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

zeljkoX
zeljkoX previously approved these changes Mar 8, 2024
View reviewed changes
shahnami
shahnami reviewed Sep 27, 2024
View reviewed changes
packages/approval-process/src/models/approval-process.ts
| 'Gnosis Safe'
| 'Safe'
| 'Gnosis Multisig'
| 'Relayer'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for relayer groups we need to add "Relayer Group" type here.

shahnami
shahnami reviewed Sep 27, 2024
View reviewed changes
packages/approval-process/src/models/approval-process.ts
timelock?: Timelock;
multisigSender?: string;
fireblocks?: FireblocksProposalParams;
relayerId?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also relayerGroupId

@MCarlomagno MCarlomagno force-pushed the plat-1635-expose-approval-process-endpoints-to-external-api-and branch from 45384d8 to 29131fb Compare October 4, 2024 21:55
@MCarlomagno MCarlomagno changed the title Add approval process create API + example feat: Add approval process create API + example Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahnami shahnami shahnami approved these changes

@zeljkoX zeljkoX zeljkoX left review comments

@collins-w collins-w Awaiting requested review from collins-w collins-w is a code owner

@CoveMB CoveMB Awaiting requested review from CoveMB CoveMB is a code owner

@dylankilkenny dylankilkenny Awaiting requested review from dylankilkenny dylankilkenny is a code owner

@emnul emnul Awaiting requested review from emnul emnul is a code owner

@tirumerla tirumerla Awaiting requested review from tirumerla tirumerla is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MCarlomagno @zeljkoX @shahnami