Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scarb to 2.8.3 #1166

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

ericnordelo
Copy link
Member

Bump scarb to the latest version.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (6837fe1) to head (e9cd67d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          57       57           
  Lines        1375     1375           
=======================================
  Hits         1222     1222           
  Misses        153      153           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6837fe1...e9cd67d. Read the comment docs.

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

### Changed

- Bump scarb to v2.8.3 (#1166)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we usually specify this as a breaking change? Or maybe 2.8.3 does not have any breaking changes and we are good this way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't have any breaking change, so I didn't add it to the breaking sections. With this said, the compiler version sometimes doesn't follow semver, and we've had issues with a minor bump breaking, and that's why we usually add it to the breaking section. This time is just a scarb bump, and not a cairo version bump, so it is safer.

@ericnordelo ericnordelo merged commit 8ef6a41 into OpenZeppelin:main Oct 2, 2024
8 checks passed
@ericnordelo ericnordelo deleted the feat/bump-scarb-to-2.8.3 branch October 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants