Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DualCase dispatchers #1163

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

ericnordelo
Copy link
Member

@ericnordelo ericnordelo commented Sep 25, 2024

Fixes #1128

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (32a8d2b) to head (d017517).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
+ Coverage   88.87%   91.51%   +2.63%     
==========================================
  Files          57       46      -11     
  Lines        1375     1178     -197     
==========================================
- Hits         1222     1078     -144     
+ Misses        153      100      -53     
Files with missing lines Coverage Δ
...ges/account/src/extensions/src9/snip12_utils.cairo 47.05% <ø> (ø)
packages/account/src/extensions/src9/src9.cairo 91.66% <100.00%> (ø)
packages/token/src/erc1155/erc1155.cairo 98.96% <100.00%> (ø)
...kages/token/src/erc20/extensions/erc20_votes.cairo 94.11% <100.00%> (ø)
packages/token/src/erc721/erc721.cairo 90.24% <100.00%> (-0.82%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a8d2b...d017517. Read the comment docs.

* feat: remove modules

* fix: mock

* fix: linter

* fix: tests

* fix: mock

* feat: apply review suggestions
@ericnordelo ericnordelo mentioned this pull request Oct 4, 2024
ericnordelo and others added 3 commits October 6, 2024 19:55
* feat: update docs

* feat: update CHANGELOG

* fix: typo

* fix: mod

* feat: remove unused imports

* fix: README

* feat: remove selectors

* Update docs/modules/ROOT/pages/interfaces.adoc

Co-authored-by: Andrew Fleming <[email protected]>

* feat: add mention and link to dispatcher types

* feat: remove import

* Update docs/modules/ROOT/pages/interfaces.adoc

Co-authored-by: Andrew Fleming <[email protected]>

* fix: README

---------

Co-authored-by: Andrew Fleming <[email protected]>
@ericnordelo ericnordelo marked this pull request as ready for review October 7, 2024 18:59
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove DualDispatchers
2 participants