Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/cleanup_resource_files #79

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

refactor/cleanup_resource_files #79

wants to merge 1 commit into from

Conversation

JarbasAl
Copy link
Member

No description provided.

@JarbasAl JarbasAl added breaking refactor code improvements with no functional changes labels Apr 24, 2023
@JarbasAl JarbasAl requested review from NeonDaniel and a team April 24, 2023 00:16
NeonDaniel
NeonDaniel requested changes May 17, 2023
View reviewed changes
Copy link
Member

@NeonDaniel NeonDaniel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rebased on dev and unit tests then updated to include tests for added ResourceFile classes

@JarbasAl
Copy link
Member Author

JarbasAl commented May 17, 2023 •
edited
Loading

since this one is a breaking change (init method signature) it should wait for core 0.0.8 to be released first (with companion workshop stable release) before merging

@NeonDaniel NeonDaniel marked this pull request as draft July 11, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel requested changes

@emphasize emphasize Awaiting requested review from emphasize

Assignees
No one assigned
Labels
breaking refactor code improvements with no functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JarbasAl @NeonDaniel