Feature: Identity Verification iOS Implementation #1038
+92
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Token added as parameter to login - updateUserJwt - UserJwtInvalidatedEvent - Add & Remove Listener methods
- new methods updateUserJwt and addUserJwtInvalidatedListener added to the bridge
- iOS v. 5.3.0-beta-01
- Make it clear that null must be passed to native layer
- Explicitly add that this class conforms to OSUserJwtInvalidatedListener protocol
nan-li
reviewed
Dec 26, 2024
| login(externalId: string): void { | ||
| window.cordova.exec(function () { }, function () { }, "OneSignalPush", "login", [externalId]); | ||
| login(externalId: string, jwtToken?: string): void { | ||
| // if no jwt token, pass null |
There was a problem hiding this comment.
// if no jwt token, pass null
Is this comment accurate?
nan-li
approved these changes
Dec 26, 2024
nan-li
requested changes
Dec 26, 2024
| bool first = addUserJwtInvalidatedListenerCallbackId == nil; | ||
| addUserJwtInvalidatedListenerCallbackId = command.callbackId; | ||
| if (first) { | ||
| [OneSignal addUserJwtInvalidatedListener:self]; |
There was a problem hiding this comment.
I don't see (void)onUserJwtInvalidatedWithEvent in this PR. Were you able to test the invalidated callback firing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Implement identity verification functionality to our Cordova SDK.
NOTE: this is a new PR. For previous discussion please see #1033
Details
Implement identity verification functionality to our Cordova SDK with JWT (JSON Web Token) that manage a specific User, their Subscriptions, and Identities, if enabled using OneSignal dashboard.
Motivation
The OneSignal Identity Verification feature only exists today for the Player model; we want to add this functionality to the User Model SDKs.
Scope
This PR only encapsulates changes to the Cordova wrapper and iOS bridge. A future PR will include Android implementation.
Testing
Manual testing
Testing was done with the iOS beta release v. 5.3.0-beta-01. Another round of testing will be completed when out of pre-release.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is