Update make transformations logs and contextualizations #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcowgill
reviewed
Jul 31, 2024
|
|
||
| if (transaction.receipt?.logs) { | ||
| return transaction.receipt.logs.map((log) => { | ||
| return { |
There was a problem hiding this comment.
@ponyjackal I think we may need to add chainId too. Do any contextualizations depend on that?
There was a problem hiding this comment.
If so, we can circle back to that in a follow-up PR
pcowgill
reviewed
Jul 31, 2024
pcowgill
reviewed
Jul 31, 2024
| @@ -28,7 +28,7 @@ export function detect(transaction: Transaction): boolean { | |||
| * and it also serves to decouple the logic, thereby simplifying the testing process | |||
| */ | |||
| const originChainId = transaction.chainId ?? 1; | |||
| const logs = transaction.logs ?? []; | |||
| const logs = grabLogsFromTransaction(transaction); | |||
There was a problem hiding this comment.
@ponyjackal I worry that future contributors may not remember to use this helper when writing new contextualizations. This isn't blocking feedback for this PR, but can we make this change somewhere upstream, to ensure that it works even if people use transaction.logs without the helper?
There was a problem hiding this comment.
I created a Linear issue to track this as a separate task
pcowgill
reviewed
Jul 31, 2024
| @@ -48,6 +48,10 @@ import ensBulkRenew0x25add712 from './test/transactions/ensBulkRenew-0x25add712. | |||
| import skyoneerPlotAction0x9436b659 from './test/transactions/skyoneerPlotAction-0x9436b659.json'; | |||
| import skyoneerPlotAction0x9bb5a737 from './test/transactions/skyoneerPlotAction-0x9bb5a737.json'; | |||
| import skyoneerPlotAction0x496c6309 from './test/transactions/skyoneerPlotAction-0x496c6309.json'; | |||
| // untransformed transactions | |||
There was a problem hiding this comment.
Nice, thanks for adding this
pcowgill
approved these changes
Jul 31, 2024
…logs-and-contextualizations
pcowgill
approved these changes
Jul 31, 2024
pcowgill
deleted the
feature/ou-2726-update-make-transformations-logs-and-contextualizations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.