-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ai-telemetry skeleton folders and zookeeper #547
base: main
Are you sure you want to change the base?
Conversation
@RH-csaggin For ArgoCD to properly sync namespaces that need to be created first, we add them to a cluster-scope bundle. Let's add to this PR:
|
@RH-csaggin I like your idea about using ArgoCD's CreateNamespace option. Let's try that instead of the bundle: apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
name: zookeeper
spec:
destination:
namespace: zookeeper
syncPolicy:
syncOptions:
- CreateNamespace=true |
- added back the volumeClaimTemplates and removed pvc to allow scaling. - prefix to have it more agnostic. - add namespace to base/zookeeper/kustomization to apply to all the resoruces. - rectify limits preventing slowing the application. - set replica to 3 for production ready HA.
@computate In my testing env using RH GitOps the automated creation of the namespace worked fine with a manifest like this: apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
name: zookeeper
spec:
destination:
namespace: zookeeper
server: https://kubernetes.default.svc
source:
path: ai-telemetry/overlays/nerc-ocp-obs
repoURL: https://github.com/RH-csaggin/nerc-ocp-config.git
targetRevision: HEAD
kustomize:
namespace: zookeeper
sources: []
project: default
syncPolicy:
automated:
prune: true
selfHeal: true
syncOptions:
- CreateNamespace=true
managedNamespaceMetadata:
labels:
argocd.argoproj.io/managed-by: openshift-gitops To allow cluster-resources to be created correctly I had to add the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked together this morning
looking good!
@larsks In the comment above #547 (comment), @RH-csaggin discovered a clever way for ArgoCD to automatically create the namespace that we need for this PR to add zookeeper to the obs cluster. do you see any issues with adding these syncOptions to our ArgoCD Application instead of creating a spec:
destination:
namespace: zookeeper
syncPolicy:
syncOptions:
- CreateNamespace=true
managedNamespaceMetadata:
labels:
argocd.argoproj.io/managed-by: openshift-gitops |
This will also need an argocd app defined in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rerun the helm chart with replicaCount=3
to fix some StatefulSet configuration for 3 replicas.
@RH-csaggin after a discussion with @larsks , the goal for the nerc-ocp-config repo is to have a yaml resource for everything, including namespaces. So we don't want ArgoCD to automatically create our So let's go back to the original plan. For ArgoCD to properly sync namespaces that need to be created first, we add them to a cluster-scope bundle. Let's add to this PR:
|
namePrefix: obs-
for a better identification.oc kustomize overlays/nerc-ocp-obs | oc create -f - -n zookeeper-obs