[IMP] sign_oca: Allow to store geolocalization #16
Conversation
etobella
force-pushed
the
16.0-geolocalization
branch
from
1c2d9fa
to
fa2dc13
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@etobella can you rebase please ? |
etobella
force-pushed
the
16.0-geolocalization
branch
from
fa2dc13
to
d8d96f7
Compare
etobella
force-pushed
the
16.0-geolocalization
branch
from
d8d96f7
to
b490bad
Compare
|
@WesleyOliveira98, could you please review? |
There was a problem hiding this comment.
[FUNCTIONAL REVIEW]
Create a Sign Oca Template with Ask Location enabled
Testing on Runboat (which uses HTTP), the browser blocks geolocation retrieval. This is a standard security restriction for pages not served over HTTPS. As a result, it consistently returns an error.
TypeError: Cannot read properties of undefined (reading 'latitude')
at SignOcaPdfPortal._onClickSign (http://oca-sign-16-0-pr16-b490badf47d5.runboat.odoo-community.org/web/assets/212-b5b3804/web.assets_frontend.min.js:9355:80)
To work around this, I had to run Chrome with the following command (using Ubuntu):
google-chrome --unsafely-treat-insecure-origin-as-secure="http://oca-sign-16-0-pr16-b490badf47d5.runboat.odoo-community.org/" --user-data-dir=/tmp/chrome_dev_test
This allowed me to enable location access for Runboat and proceed with the signing process. It worked perfectly, and the system correctly retrieved my latitude and longitude.
And then, i reopened Chrome with the flags and blocked the site from accessing the geolocation, which resulted in the same error as before.
| kwargs: { | ||
| latitude: position.coords.latitude, | ||
| longitude: position.coords.longitude, | ||
| }, |
There was a problem hiding this comment.
I think you should prevent the error in the code by handling the possibility of geolocation not being available. For example:
latitude: position ? position.coords.latitude : false,
longitude: position ? position.coords.longitude : false,
| params: { | ||
| items: this.info.items, | ||
| latitude: position.coords.latitude, | ||
| longitude: position.coords.longitude, | ||
| }, |
There was a problem hiding this comment.
I think you should prevent the error in here as well
| @@ -430,7 +434,7 @@ def sign(self): | |||
| "url": self.access_url, | |||
| } | |||
|
|
|||
| def action_sign(self, items, access_token=False): | |||
| def action_sign(self, items, access_token=False, latitude=False, longitude=False): | |||
There was a problem hiding this comment.
Additionally, in the actions_sign method, you could add a ValidationError if the template is marked as ask_location and the latitude and longitude are not provided.
Using geolocalization can be useful in order to prove the authorship of the signature