[FIX] SyntaxError: name '_' is used prior to global declaration #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garamotte
reviewed
Feb 8, 2018
odoo_sentinel/__init__.py
Outdated
| @@ -81,9 +84,6 @@ def __init__(self, stdscr, options): | |||
| language = gettext.translation( | |||
| I18N_DOMAIN, I18N_DIR, languages=[I18N_DEFAULT]) | |||
|
|
|||
| # Replace global dummy lambda by the translations gettext method | |||
| # The install method of gettext doesn't replace the function if exists | |||
| global _ | |||
| _ = language.gettext | |||
There was a problem hiding this comment.
You should move this line too, because the translation method is called on line 67.
sla-subteno-it
force-pushed
the
fix-global-declaration
branch
from
59146e8
to
942a426
Compare
|
@sylvain-garancher is-it ok ? |
|
No, because there is a recursive depdency issue... I think that we can simply make the |
|
sylvain cela fait 5 heures que on essaye de résoudre: on comprend rien pour faire marcher ce truc. il y a pas de tuto. un peu pas travailler comme cela. c'est de développer des logiciels, c'est encore mieux quand les autres peuvent s'en servir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before fix, we have this error :
Traceback (most recent call last):
File "/Users/alnslang/.virtualenvs/tests/bin/odoo-sentinel", line 7, in
from odoosentinel import main
File "/Users/alnslang/.virtualenvs/tests/lib/python3.6/site-packages/odoosentinel/init.py", line 87
global _
^
SyntaxError: name '_' is used prior to global declaration