[FIX] fieldservice_account_analytic: automatically fill Contact in FSM Order #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M Order When customer_id is not set in the order we have: > "customer_id" not in vals and order.customer_id is False > False > "customer_id" not in vals and not order.customer_id > True
|
Hi @osimallen, @brian10048, @bodedra, |
|
Tests are failing due to https://github.com/OCA/field-service/blob/cf1f50e498036043ac08c41ed3ac803fdef1f446/fieldservice_stock_account/models/fsm_order.py#L52 is no longer raised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start by saying that the logical behind it is not clear to me, during a debug session I noticed the following problem.
To Reproduce
Steps to reproduce the behavior:
location_idfieldExpected behavior
Contact is automatically filled with that one of the Location.
Additional context
In debug we have: