-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.ibis-framework: 2.1.1 -> 3.0.2 #170756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 170756 run on x86_64-linux 1
8 packages built:
- python310Packages.duckdb-engine
- python310Packages.ibis-framework
- python310Packages.ipython-sql
- python310Packages.poetry-dynamic-versioning
- python39Packages.duckdb-engine
- python39Packages.ibis-framework
- python39Packages.ipython-sql
- python39Packages.poetry-dynamic-versioning
The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
got build log for '/nix/store/1n92xqmf4r3bky80xxm3wq0fa3cp8mns-python3.10-duckdb-engine-0.1.8' from 'daemon'
When evaluating attribute ‘python310Packages.duckdb-engine’:
warning: unused-argument
Unused argument: pytest.
Near pkgs/development/python-modules/duckdb-engine/default.nix:10:3:
────────────────────
|
10 | , pytest
| ^
────────────────────
d1c7b24
to
59bc9fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work! I have only some minor suggestions.
59bc9fd
to
67d44c9
Compare
@gador Done! Thanks for the review. |
67d44c9
to
9691eba
Compare
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 8 packages built:
|
LGTM. Before merging I'd suggest rebasing some of the commits, so we only have one commit per package |
Sounds good. There's one more thing to fix which is to bump to 3.0.2 so the version number is correct 😄 . |
9691eba
to
2e75d97
Compare
@gador Squashed, this should be good to merge! Thanks again. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
2e75d97
to
5f8b64a
Compare
|
5f8b64a
to
095d5f5
Compare
095d5f5
to
95092c3
Compare
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes