Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ibis-framework: 2.1.1 -> 3.0.2 #170756

Merged
merged 4 commits into from
May 1, 2022

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Apr 28, 2022

Description of changes
  • python3Packages.poetry-dynamic-versioning: init at 0.14.1
  • python3Packages.ipython-sql: init at 0.4.0
  • python3Packages.duckdb-engine: init at 0.1.8
  • python3Packages.ibis-framework: 2.1.1 -> 3.0.2
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@gador gador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 170756 run on x86_64-linux 1

8 packages built:
  • python310Packages.duckdb-engine
  • python310Packages.ibis-framework
  • python310Packages.ipython-sql
  • python310Packages.poetry-dynamic-versioning
  • python39Packages.duckdb-engine
  • python39Packages.ibis-framework
  • python39Packages.ipython-sql
  • python39Packages.poetry-dynamic-versioning

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python310Packages.duckdb-engine:

got build log for '/nix/store/1n92xqmf4r3bky80xxm3wq0fa3cp8mns-python3.10-duckdb-engine-0.1.8' from 'daemon'
When evaluating attribute ‘python310Packages.duckdb-engine’:
warning: unused-argument
Unused argument: pytest.
Near pkgs/development/python-modules/duckdb-engine/default.nix:10:3:

────────────────────
|
10 | , pytest
| ^
────────────────────

@cpcloud cpcloud force-pushed the bump-ibis-framework branch 3 times, most recently from d1c7b24 to 59bc9fd Compare April 30, 2022 13:21
Copy link
Member

@gador gador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work! I have only some minor suggestions.

@cpcloud
Copy link
Contributor Author

cpcloud commented Apr 30, 2022

@gador Done! Thanks for the review.

@gador
Copy link
Member

gador commented Apr 30, 2022

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 170756 run on x86_64-linux 1

8 packages built:
  • python310Packages.duckdb-engine
  • python310Packages.ibis-framework
  • python310Packages.ipython-sql
  • python310Packages.poetry-dynamic-versioning
  • python39Packages.duckdb-engine
  • python39Packages.ibis-framework
  • python39Packages.ipython-sql
  • python39Packages.poetry-dynamic-versioning

@gador
Copy link
Member

gador commented Apr 30, 2022

LGTM. Before merging I'd suggest rebasing some of the commits, so we only have one commit per package

@cpcloud
Copy link
Contributor Author

cpcloud commented Apr 30, 2022

Sounds good. There's one more thing to fix which is to bump to 3.0.2 so the version number is correct 😄 .

@cpcloud cpcloud changed the title python3Packages.ibis-framework: 2.1.1 -> 3.0.0 python3Packages.ibis-framework: 2.1.1 -> 3.0.2 Apr 30, 2022
@cpcloud
Copy link
Contributor Author

cpcloud commented Apr 30, 2022

@gador Squashed, this should be good to merge! Thanks again.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/495

@risicle
Copy link
Contributor

risicle commented Apr 30, 2022

nixpkgs-review reveals no new failures, macos 10.15 & nixos x86_64.

@cpcloud cpcloud requested a review from risicle May 1, 2022 13:34
@risicle risicle merged commit b455605 into NixOS:master May 1, 2022
@cpcloud cpcloud deleted the bump-ibis-framework branch May 1, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants