Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nix-shell --pure to avoid running externally installed tools #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noamraph
Copy link
Contributor

I followed the original instructions, and was expecting to see bash: make: command not found, but instead found make to be installed.

I realized that it was the make from my own system. It seems to me better to not have the tools from my own system available. So I suggest adding --pure to the instructions, with an explanation of what it does.

Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--pure is quite annoying if you e.g. use nano to edit the files. And, in the past I had it break shell prompt IIRC (not sure what was responsible).

@noamraph
Copy link
Contributor Author

@jtojnar I think that for educational reasons it's better to add --pure with an explanation, so if someone wants nano they'll know what to do. It seems to me like with --pure you're on the safe side, in an environment much similar to the build environment, and if you need your tools, you can always re-run without --pure. Also, it was just confusing to me to see that make is available, contrary to what's described, so I think it's better to avoid this confusion for other readers.

But obviously, you have much more experience that I have, so I would be fine with any decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants