Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Support for Nextra Configuration #290

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ieaves
Copy link

@ieaves ieaves commented May 30, 2023

This PR adds support for the Nextra Docs Theme to pydocs-markdown. The basic site structure is similar to docusaurus so I've reused the docusaurus renderer without the sidebar.json.

Changelog

I've attempted to add a changelog entry in accordance with the contribution-guidelines however, after installing slap-cli with pipx I received an error

slap changelog add -t changelog -d "Adds Nextra support"

> invalid change type: changelog

I eventually realized the issue was with the type flag so I've included updates to the contributing markdown with references to the acceptable set of types and a typo fix.

Slap

I'm going to add these comments here since it looks like you're also the author of Slap but it looks like slaps docs build might have failed pulling in the readme from the project root see here.

@ieaves
Copy link
Author

ieaves commented Jun 7, 2023

Any chance you have some time to look at this @NiklasRosenstein ?

@NiklasRosenstein
Copy link
Owner

Hey @ieaves , thanks for the PR! I hope to find some time later this week.

@ieaves
Copy link
Author

ieaves commented Jun 16, 2023

No worries! Thanks for writing this package!

@ieaves
Copy link
Author

ieaves commented Jun 23, 2023

Hey @NiklasRosenstein, any updates?

@ieaves
Copy link
Author

ieaves commented Jul 3, 2023

@NiklasRosenstein one more ping. Totally understand if nextra isn't part of your roadmap. I'm happy to maintain an alternative fork with nextra support if so but as of now it's difficult to add doc builds into our CI without something like this.

@ieaves ieaves changed the title Add's Support for Nextra Configuration Adds Support for Nextra Configuration Sep 21, 2023
@NiklasRosenstein
Copy link
Owner

NiklasRosenstein commented Nov 11, 2023

Hi @ieaves, I'm finally getting back to this! Sorry for the months long silence.

I've made a few changes from your PR on the nextra branch, including an examples/nextra folder. I'm not familiar with Nextra. Do you happen to know why the pages generated by Pydoc-Markdown in the examples/nextra/docs/pages/school/ folder are shown in the menu but nothing happens when I click on them? This feels like some configuration is missing.

image

@ieaves
Copy link
Author

ieaves commented Nov 11, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants