Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Showcase] Enchance headers with buffer id at BaseRawIO #1545

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Contributor

@h-mayorquin h-mayorquin commented Sep 4, 2024

This PR is not mean to be merged but to add a concrete implementation to suggest in #1544. This PR probably is incomplete and it has errors.

The idea here is that the BaseRawIO will add post parsing logic to modify the signal_streams and signal_channels headers by adding the buffer id if they are not in the new type yet. Same for signal_channels where the buffer id will be added as an extra column. In all of those cases the buffer_id is just a carbon copy of the stream_id.

This approach should enable the following workflow and progression plan:

  1. In one sweep all the classess should have the correct dtype for the header avoiding an intermediate state of the library where not all the formats have the same dtype for the headers.
  2. We can then approach each format piece-wise and assign the proper buffer ids and separate the streams logically.
  3. Once we are done with all the formats we can eliminate the post parsing code here and everything should be clean.

@h-mayorquin
Copy link
Contributor Author

OK, so Sam decided to do this in one sweep. Let's close this once we are finished with #1544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant