Fix setting reading the search language cookie

[joelit]

Reasons for creating this PR

There was a bug reading the content language cookie, due to a method not being updated to follow the new cookie convention. This PR is built upon #1689 .

Link to relevant issue(s), if any

• Closes Content language setting is not working consistently in Skosmos 3 #1692

Description of the changes in this PR

Changed the name of the cookie

Known problems or uncertainties in this PR

• Should there be an additional test to catch the bug described in Content language setting is not working consistently in Skosmos 3 #1692 ?
• Does this bug warrant a closer inspection of the content language & UI language management logic?

Checklist

• phpUnit tests pass locally with my changes
• I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
• The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
• The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[osma]

This is not the right way to fix #1692. There are, or should be, two cookies: SKOSMOS_LANGUAGE to remember the UI language and SKOSMOS_SEARCH_LANG to remember the content/search language. Whether we actually need the latter is debatable (as explained in #1692) but mixing up these two doesn't help.

[joelit]

I don't think nothing sets the SKOSMOS_LANGUAGE cookie anymore, though. It looks like it's becoming dead code in 3.0.

[osma]

I don't think nothing sets the SKOSMOS_LANGUAGE cookie anymore, though. It looks like it's becoming dead code in 3.0.

You're right that it's not being set by the current Skosmos 3 code. In the Skosmos 2 code, we set event handlers for the UI language selection links:

Skosmos/resource/js/docready.js

Lines 488 to 494 in 6b9b380

	// Event handlers for the language selection links for setting the cookie
	$('#language a').each( function(index, el) {
	$(el).on('click', function() {
	var langCode = el.id.substr(el.id.indexOf("-") + 1);
	setLangCookie(langCode);
	});
	});

I think the same should be done for Skosmos 3. I can open a new issue about this.

[osma]

Opened a new issue #1696