Skip to content

Commit

Permalink
feat: add api gateway
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelpuiggarcia committed Sep 3, 2023
1 parent 676a6a1 commit 4d4c379
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 5 deletions.
10 changes: 5 additions & 5 deletions gcp/cloud-run-v2/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,9 @@ module "cloud_run_alerts" {
source = "../cloud-alerts"
project_id = var.project_id
service_name = var.name
alert_notification_channels = []
error_rate_threshold = 20.0
error_rate_duration = "600s"
latency_threshold = 2000.0
latency_duration = "600s"
alert_notification_channels = var.alert_config.alert_notification_channels
error_rate_threshold = var.alert_config.error_rate_threshold
error_rate_duration = var.alert_config.error_rate_duration
latency_threshold = var.alert_config.latency_threshold
latency_duration = var.alert_config.latency_duration
}
46 changes: 46 additions & 0 deletions gcp/cloud-run-v2/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,49 @@ variable "service_path" {
description = "Location for the main code and where the cloudbuild.yaml exists, for example /services/myapi"
type = string
}


variable "trigger_config" {
description = "Configuration for the Cloud Build Trigger"
type = object({
name = string
repository_name = string
description = string
filename = string
include = list(string)
exclude = list(string)
environment = string
substitutions = map(string)
create_trigger = bool
})
default = {
name = "default-trigger-name"
repository_name = "default-repo-name"
description = "default-description"
filename = "cloudbuild.yaml"
include = []
exclude = []
environment = null
substitutions = {}
create_trigger = true
}
}


variable "alert_config" {
description = "Configuration for alerts"
type = object({
alert_notification_channels = list(string)
error_rate_threshold = number
error_rate_duration = string
latency_threshold = number
latency_duration = string
})
default = {
alert_notification_channels = []
error_rate_threshold = 10.0
error_rate_duration = "300s"
latency_threshold = 1000.0
latency_duration = "300s"
}
}
7 changes: 7 additions & 0 deletions test/gcp/cloud-run-v2.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,11 @@ module "cloud-run" {
"SECRET_ONE",
"SECRET_TWO"
]
alert_config = {
alert_notification_channels = ["your-notification-channel-id"]
error_rate_threshold = 20.0
error_rate_duration = "600s"
latency_threshold = 2000.0
latency_duration = "600s"
}
}

0 comments on commit 4d4c379

Please sign in to comment.