Add infrastructure files #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeHart85
reviewed
Sep 3, 2020
LICENSE
Outdated
| @@ -0,0 +1,29 @@ | |||
| BSD 3-Clause License | |||
|
|
|||
| Copyright (c) 2020, Brookhaven Science Associates, Brookhaven National Laboratory | |||
There was a problem hiding this comment.
This does not need to name BSA and should just name BNL, like so:
Copyright (c) 2020, Brookhaven National Laboratory
See @stuartcampbell's comment on this issue.
There was a problem hiding this comment.
OK, thanks for pointing it out. I actually copied it from SRX, I'll correct it there as well.
|
This is done for now. I tested the code correctly handles the versions of the package based on the tag/number of commits from tag. CI can be enabled in a separate PR. |
|
Please note this commit: 5466d2e. It's only needed when we render |
jklynch
requested changes
Sep 4, 2020
MikeHart85
approved these changes
Sep 4, 2020
jklynch
approved these changes
Sep 4, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
MANIFEST.infor source distributionrequirements.txtsetup.pybased on https://github.com/NSLS-II/nslsii/blob/master/setup.py (to be updated to use https://github.com/NSLS-II/scientific-python-cookiecutter/blob/master/%7B%7B%20cookiecutter.repo_name%20%7D%7D/setup.py)