Skip to content

upgrade badger

upgrade badger #181

Triggered via push October 8, 2024 08:17
Status Success
Total duration 2m 49s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 11 warnings
lint: util/base58/doc.go#L9
File is not `gofmt`-ed with `-s` (gofmt)
lint: go.mod#L5
replacement are not allowed: github.com/dgraph-io/badger/v4 (gomoddirectives)
lint: util/base58/base58.go#L36
Duplicate words (j) found (dupword)
lint: util/base58/base58.go#L13
bigRadix is a global variable (gochecknoglobals)
lint: util/base58/base58.go#L27
bigRadix10 is a global variable (gochecknoglobals)
lint: util/base58/base58.go#L15
Magic number: 58, in <argument> detected (gomnd)
lint: util/base58/base58.go#L16
Magic number: 58, in <argument> detected (gomnd)
lint: util/base58/base58.go#L17
Magic number: 58, in <argument> detected (gomnd)
lint: util/base58/base58.go#L97
Magic number: 1.365658237309761, in <argument> detected (gomnd)
lint: util/base58/base58check.go#L29
Magic number: 4, in <argument> detected (gomnd)
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: util/base58/base58check_test.go#L61
redefines-builtin-id: redefinition of the built-in function len (revive)
lint: config/reader.go#L14
var-naming: const KernelNetworkId should be KernelNetworkID (revive)
lint: crypto/blake2b_test.go#L18
unexported-return: exported func NewBlake2bXOF returns unexported type *crypto.xof, which can be annoying to use (revive)
lint: crypto/rand.go#L32
increment-decrement: should replace set[b] += 1 with set[b]++ (revive)
lint: crypto/rand.go#L10
unexported-return: exported func RandReader returns unexported type *crypto.randReader, which can be annoying to use (revive)
lint: crypto/signature.go#L66
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
lint: crypto/signature.go#L81
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
lint: common/space.go#L8
var-naming: struct field NodeId should be NodeID (revive)
lint: common/decoding.go#L125
increment-decrement: should replace il -= 1 with il-- (revive)
lint: common/asset.go#L11
var-naming: var XINAssetId should be XINAssetID (revive)