Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depth_anythingV2 #2956

Closed
wants to merge 3 commits into from
Closed

Update depth_anythingV2 #2956

wants to merge 3 commits into from

Conversation

sdbds
Copy link
Collaborator

@sdbds sdbds commented Jun 15, 2024

@sdbds
Copy link
Collaborator Author

sdbds commented Jun 15, 2024

image

I tested it but the jaggies are noticeable, it's best to update the code in the python package just to be on the safe side
(although the code doesn't seem to have changed much when I checked it)
@huchenlei

@sdbds sdbds marked this pull request as ready for review June 15, 2024 16:42
@sdbds sdbds requested a review from huchenlei June 15, 2024 16:42
@sdbds
Copy link
Collaborator Author

sdbds commented Jun 15, 2024

image
OK,they change dino model,too

Copy link
Collaborator

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a new preprocessor for that v2 model, so that people get consistent result with same infotext.

@huchenlei
Copy link
Collaborator

image OK,they change dino model,too

I don't think that dino model change is the cause. The commit happens on Jan 15th before I fork the repo on Jan 22nd.

@kagevazquez
Copy link

kagevazquez commented Jun 18, 2024

The output from this is really pixilated when used as a drop in replacement
tmp52e31x2g
tmpe9b3aee6

maybe this is what changed LiheYoung/Depth-Anything#81

@MackinationsAi
Copy link
Contributor

MackinationsAi commented Jul 1, 2024

I have update the sd-webui-controlnet repo to support depth_anything_v2 in this forked branch if you approve the pull request I'm about to submit. Forked Repo - https://github.com/MackinationsAi/sd-webui-controlnet Pull Request - #2969

@sdbds sdbds closed this Jul 1, 2024
@sdbds
Copy link
Collaborator Author

sdbds commented Jul 1, 2024

I have update the sd-webui-controlnet repo to support depth_anything_v2 in this forked branch if you approve the pull request I'm about to submit. Forked Repo - https://github.com/MackinationsAi/sd-webui-controlnet

Thanks for your contribution, I will review as well as test it as soon as possible.

@MackinationsAi
Copy link
Contributor

I have update the sd-webui-controlnet repo to support depth_anything_v2 in this forked branch if you approve the pull request I'm about to submit. Forked Repo - https://github.com/MackinationsAi/sd-webui-controlnet

Thanks for your contribution, I will review as well as test it as soon as possible.

I still need to upload the new hf depth_anything_v2 transformers (which I will be doing next). I have tested it locally on my machine & it works really well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants