disable run preprocessor if no cn input image #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I moved the detection logic to |
tiangles
pushed a commit
to diffus-me/sd-webui-controlnet
that referenced
this pull request
Aug 18, 2023
* disable run preprocessor if no cn input image * 🚧 Move detection logic to active_units.js --------- Co-authored-by: huchenlei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #1867 and related to PR #1747, I suggest those modifications to the Javascript code.
The run preprocessor button is enabled only if an image input exists in the ControlNet input tab. The hint of the button is changed accordingly.
One problem I have:
at the first start of webui, the button is enabled without any input image. I don't know where in the code I can change this initial state. But I don't think it is a big issue as the user will not expect any result with a totally blank canvas I believe.