Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urls with query string are not working correctly. This fixes it. #65

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

ombr
Copy link
Contributor

@ombr ombr commented Jun 7, 2021

I am getting 403 from aws s3 as query_string are not passed through in the node fetch polyfill.

With this PR, I am able to parse the exifs on files stored on AWS S3 with presigned_urls. (It is another but simpler use case of #57)

From Node documentation:

path Request path. Should include query string if any. E.G.
'/index.html?page=12'. An exception is thrown when the request path
contains illegal characters. Currently, only spaces are rejected but
that may change in the future. Default: '/'.

From Node documentation:

path <string> Request path. Should include query string if any. E.G.
'/index.html?page=12'. An exception is thrown when the request path
contains illegal characters. Currently, only spaces are rejected but
that may change in the future. Default: '/'.
@MikeKovarik MikeKovarik merged commit 2bca265 into MikeKovarik:master Jun 11, 2021
@MikeKovarik
Copy link
Owner

Hello. Thank you very much for participating. Good call with that search param.
As always I'm busy so I'll try to publish along fix #66 and #62 in the coming days.

@ombr
Copy link
Contributor Author

ombr commented Jun 14, 2021

Great thanks !!

@MikeKovarik
Copy link
Owner

Hello @ombr . I'm sorry I forgot to mention that 7.1.0 was released last week.

@ombr
Copy link
Contributor Author

ombr commented Jun 28, 2021

Great thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants