-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DSD style sharing explainer #875
Open
phumai98
wants to merge
24
commits into
MicrosoftEdge:main
Choose a base branch
from
phumai98:phumai98-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
988ddc6
Create explainer.md
phumai98 6fdfcc8
Update explainer.md
phumai98 610c6ca
Create example.md
phumai98 0e90819
Add files via upload
phumai98 cecbfb0
Delete ShadowDOM/images/example.md
phumai98 e9dc9ef
Update explainer.md
phumai98 01a3be5
Update ShadowDOM/explainer.md
phumai98 68c6792
Update explainer.md
phumai98 8fa3be2
Update explainer.md
phumai98 ad7e48d
Update explainer.md
phumai98 7c73790
Update explainer.md
phumai98 572a483
Update explainer.md
phumai98 8b0e062
Update ShadowDOM/explainer.md
phumai98 79e09ab
Update explainer.md
phumai98 5037d9c
Update explainer.md
phumai98 fe57f58
Update explainer.md
phumai98 6f6d52c
Merge branch 'MicrosoftEdge:main' into phumai98-patch-1
phumai98 4ad5492
Delete ShadowDOM/images/bing serp.png
phumai98 a17e829
Add files via upload
phumai98 41e05f4
Update explainer.md
phumai98 8531cf5
Update explainer.md
phumai98 045e9a3
Add files via upload
phumai98 465c39e
Delete ShadowDOM/images/bingserp.png
phumai98 3ceedf3
Merge branch 'MicrosoftEdge:main' into phumai98-patch-1
phumai98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should update the example to something similar to what is seen in the wild. Potentially a fake page with a table of contents section on the right or left?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an additional sentence like this will suffice, what do you think? "This pattern of pages with sub-sections are often seen in blogs, search result pages, pages that has a separate table of content, etc".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern was less about the text but more about the example used. I'm thinking we can showcase something that is more realistic to patterns we see in the wild. I think a table of contents of some kind would be more identifiable to someone reading the explainer