Remove floating promise from constructor (#86)

src/ppom-controller.test.ts

@@ -82,8 +82,10 @@ describe('PPOMController', () => {
       await flushPromises();
       expect(spy).toHaveBeenCalledTimes(6);
     });
+  });
 
-    it('should create instance of PPOMController even if there is an error in initialising PPOM', async () => {
+  describe('usePPOM', () => {
+    it('should throw error if there is an error in initialising PPOM', async () => {
       buildFetchSpy();
       ppomController = buildPPOMController({
         ppomProvider: {
@@ -95,11 +97,13 @@ describe('PPOMController', () => {
       jest.advanceTimersByTime(REFRESH_TIME_INTERVAL);
       await flushPromises();
 
-      expect(ppomController).toBeDefined();
+      await expect(async () => {
+        await ppomController.usePPOM(async () => {
+          return Promise.resolve();
+        });
+      }).rejects.toThrow('Error initializing PPOM');
     });
-  });
 
-  describe('usePPOM', () => {
     it('should provide instance of ppom to the passed ballback', async () => {
       buildFetchSpy();
       ppomController = buildPPOMController();

src/ppom-controller.ts

@@ -306,11 +306,6 @@ export class PPOMController extends BaseControllerV2<
 
     // start scheduled task to fetch data files
     this.#checkScheduleFileDownloadForAllChains();
-
-    // Async initialisation of PPOM as soon as controller is constructed and not when transactions are received
-    // This helps to reduce the delay in validating transactions.
-    // eslint-disable-next-line @typescript-eslint/no-floating-promises
-    this.#initialisePPOM();
   }
 
   /**
@@ -383,8 +378,9 @@ export class PPOMController extends BaseControllerV2<
           await ppomInit('./ppom_bg.wasm');
           this.#ppomInitialised = true;
         })
-        .catch(() => {
+        .catch((error: unknown) => {
           console.error('Error in trying to initialize PPOM');
+          throw error;
         });
     }
   }