Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always re-emit display uri event #1066

Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat: always re-emit display uri event #1066

merged 1 commit into from
Oct 8, 2024

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Oct 8, 2024

Explanation

Some clients implementation rely on the display_uri event being re-triggered every time the modal is opened.
This PR automatically republish the uri so that clients don't have to implement their own cache of the display_uri.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s requested a review from a team as a code owner October 8, 2024 05:48
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.10%. Comparing base (a9c7116) to head (9ef2089).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kages/sdk/src/provider/initializeMobileProvider.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
- Coverage   78.14%   78.10%   -0.04%     
==========================================
  Files         179      179              
  Lines        4155     4157       +2     
  Branches     1022     1023       +1     
==========================================
  Hits         3247     3247              
- Misses        908      910       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Contributor

@elefantel elefantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit 57cce89 into main Oct 8, 2024
35 of 37 checks passed
@abretonc7s abretonc7s deleted the displayuri branch October 8, 2024 07:02
@abretonc7s abretonc7s mentioned this pull request Oct 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants