improve handling concurrent threaded communication

MetaMask · Sep 11, 2024 · d153d45 · d153d45
1 parent 79949ff
commit d153d45
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 19 deletions.
diff --git a/metamask-android-sdk/build.gradle b/metamask-android-sdk/build.gradle
@@ -53,7 +53,6 @@ dependencies {
     implementation 'androidx.appcompat:appcompat:1.6.1'
     implementation 'com.google.android.material:material:1.9.0'
     implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
-    implementation 'androidx.test.ext:junit-ktx:1.1.5'
     implementation "androidx.lifecycle:lifecycle-livedata-ktx:2.6.1"
 
     testImplementation 'junit:junit:4.13.2'

diff --git a/metamask-android-sdk/src/test/java/io/metamask/androidsdk/EthereumTests.kt b/metamask-android-sdk/src/test/java/io/metamask/androidsdk/EthereumTests.kt
@@ -264,7 +264,7 @@ class EthereumTests {
     private fun findRequestIdForAccountRequest(method: EthereumMethod): String {
         return communicationClient.submittedRequests.entries.find {
             it.value.request.method == method.value
-        }?.key ?: throw IllegalStateException("No account request found")
+        }?.key ?: ""
     }
 
     private fun prepareCommunicationClient() {

diff --git a/nativesdk/README.md b/nativesdk/README.md
@@ -5,6 +5,19 @@ The MetaMask Android SDK Native Module is a Kotlin [Android Native Module](https
 
 This module handles encrypted communication between the dapp and MetaMask and then relays the messages over to the Android SDK communication layer implemented in React Native in the wallet. The wallet calls the Native Module via  NativeModules - an API that enables react-native code to call native Kotlin primitives.
 
+## Compiling
+To compile the nativesdk as a `.aar` file, you need to modify the project's `settings.gradle` file to have the nativesdk as a standalone module to include to the project:
+```
+include ':app'
+include ':nativesdk'
+include ':metamask-android-sdk'
+```
+Then run
+```
+./gradlew assembleDebug
+```
+The output file will be located in `nativesdk/build/outputs/aar`. This nativesdk library is then embedded in the MetaMask mobile in the path `android/libs/nativesdk.aar`. It becomes the server-side component of the AIDL communication mechanism described below in the Architecture section.
+
 ## Architecture
 The client SDK communicates with the server SDK (Android Native Module) via IPC implemented using AIDL. 
 

diff --git a/nativesdk/build.gradle.kts b/nativesdk/build.gradle.kts
@@ -36,13 +36,12 @@ android {
 dependencies {
 
     compileOnly(files("libs/ecies.aar"))
-    implementation("com.facebook.react:react-native:+")
+    implementation("com.facebook.react:react-android:0.73.3")
     implementation("androidx.core:core-ktx:1.7.0")
     implementation ("com.squareup.okhttp3:okhttp:4.9.2")
     implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.5.0")
     implementation("androidx.appcompat:appcompat:1.6.1")
     implementation("com.google.android.material:material:1.9.0")
     testImplementation("junit:junit:4.13.2")
-    androidTestImplementation("androidx.test.ext:junit:1.1.5")
     androidTestImplementation("androidx.test.espresso:espresso-core:3.5.1")
 }
diff --git a/nativesdk/src/main/java/io/metamask/nativesdk/CommunicationClient.kt b/nativesdk/src/main/java/io/metamask/nativesdk/CommunicationClient.kt
@@ -97,15 +97,6 @@ class CommunicationClient(reactContext: ReactApplicationContext) : ReactContextB
         connectionStatusManager.onMetaMaskBroadcastUnregistered()
     }
 
-    override fun invalidate() {
-        super.invalidate()
-        Logger.log("CommunicationClient:: invalidate - app terminated")
-
-        if (!didPerformTearDown) {
-            destroyActiveConnections()
-        }
-    }
-
     override fun onCatalystInstanceDestroy() {
         super.onCatalystInstanceDestroy()
         Logger.log("CommunicationClient:: onCatalystInstanceDestroy - app terminating")
@@ -142,13 +133,14 @@ class CommunicationClient(reactContext: ReactApplicationContext) : ReactContextB
 
         Logger.log("CommunicationClient:: Binding native module")
         val intent = Intent(reactAppContext, MessageService::class.java)
-        return reactAppContext.bindService(
+        val success = reactAppContext.bindService(
             intent,
             serviceConnection,
             Context.BIND_IMPORTANT)
 
         // Metamask ready, start sending messages
         connectionStatusManager.onMetaMaskReady()
+        return success
     }
 
     @ReactMethod
@@ -184,7 +176,7 @@ class CommunicationClient(reactContext: ReactApplicationContext) : ReactContextB
 
         if (type == "ready") {
             val dataJson = json.optJSONObject("data")
-            val id = dataJson.optString("id")
+            val id = dataJson?.optString("id")
             val sessionId = SessionManager.getInstance().sessionId
 
             if (id != sessionId) {

diff --git a/nativesdk/src/main/java/io/metamask/nativesdk/KeyExchange.kt b/nativesdk/src/main/java/io/metamask/nativesdk/KeyExchange.kt
@@ -48,9 +48,7 @@ class KeyExchange {
 
     fun resetKeys() {
         privateKey = crypto.generatePrivateKey()
-        privateKey?.let {
-            publicKey = crypto.publicKey(it)
-        }
+        publicKey = crypto.publicKey(privateKey)
         setIsKeysExchanged(false)
         theirPublicKey = null
     }

diff --git a/nativesdk/src/main/java/io/metamask/nativesdk/MessageService.kt b/nativesdk/src/main/java/io/metamask/nativesdk/MessageService.kt
@@ -205,7 +205,7 @@ class MessageService : Service(), MetaMaskConnectionStatusCallback {
 
             Logger.log("MessageService:: $keysExchangedMessage")
             val payload = keyExchange.encrypt(keysExchangedMessage)
-            sendMessage(payload)
+            sendMessage(message=payload)
         }
     }