Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NetworkController NetworkConfiguration actions and events #4698

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add NetworkController NetworkConfiguration actions and events #4698

wants to merge 1 commit into from

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Sep 13, 2024 •
edited
Loading

Explanation

This adds and exposes actions and events when adding, updating, or removing a NetworkConfiguration.

Events:

  • NetworkController:networkAdded
  • NetworkController:networkUpdated
  • NetworkController:networkRemoved

Actions

  • NetworkController:addNetwork
  • NetworkController:updateNetwork
  • NetworkController:removeNetwork

References

https://consensyssoftware.atlassian.net/browse/NOTIFY-1089

Changelog

@metamask/network-controller

  • ADDED: add events NetworkController:networkAdded; NetworkController:networkUpdated; NetworkController:networkRemoved
  • ADDED: add actions NetworkController:addNetwork; NetworkController:updateNetwork; NetworkController:removeNetwork

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Sep 13, 2024
@Prithpal-Sooriya
feat: add NetworkController actions and events
2226588 
actions and events for adding, updating, and removing a network configuration
@Prithpal-Sooriya Prithpal-Sooriya force-pushed the NOTIFY-1089/add-network-events-actions branch from 5c85bb9 to 2226588 Compare September 13, 2024 14:01
@Prithpal-Sooriya Prithpal-Sooriya mentioned this pull request Sep 13, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Prithpal-Sooriya