-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate between Kubevirt and OpenShift Virtualization #1815
base: master
Are you sure you want to change the base?
Conversation
| Events | ✅ | ✅ | ✅ | ✅ | ❌ | | ||
| Metrics | ✅ | ✅ | ✅ | ✅ | ❌ | | ||
| Forensic Analysis (SmartState) | ✅ | ✅ | ✅ (Nodes) | ❌ | ❌ | | ||
| Discovery | vSphere | oVirt / RHV | OpenStack undercloud | IBM Power HMC | KubeVirt | OSV | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we show the other subclassed providers together, oVirt / RHV
Could we do | KubeVirt / OSV |
at least until we have any differentiation between the two in features supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need to update the capability matrix with KubeVirt / OSV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is there https://github.com/ManageIQ/manageiq-documentation/blob/master/capabilities_matrix/_topics/infrastructure_providers.md, the earlier change was just to separate it but no longer doing that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 I didn't see that in the diff, thanks
66a5eea
to
3b98672
Compare
Post subclassing OSV, we should differentiate it as a separate provider from Kubevirt in the docs
@miq-bot assign @agrare
@miq-bot add_labels enhancement, radjabov/yes?
@miq-bot add_reviewers @agrare, @Fryguy