Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2020 #2112

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Fix #2020 #2112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcdf0fb
Added a warning when trying to save c-TF-IDF matrix while it is None.
saif-alnajjar-places Aug 4, 2024
dd19cb2
Changed to if/else instead of returning when checking if the c-TF-IDF…
sete39 Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions bertopic/_bertopic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3346,12 +3346,18 @@ def save(

# Additional
if save_ctfidf:
save_utils.save_ctfidf(
model=self,
save_directory=save_directory,
serialization=serialization,
)
save_utils.save_ctfidf_config(model=self, path=save_directory / "ctfidf_config.json")
if self.c_tf_idf_ is None:
logger.warning(
"The c-TF-IDF matrix could not be saved as it was not found. "
"This typically occurs when merging BERTopic models with `BERTopic.merge_models`."
)
else:
save_utils.save_ctfidf(
model=self,
save_directory=save_directory,
serialization=serialization,
)
save_utils.save_ctfidf_config(model=self, path=save_directory / "ctfidf_config.json")

@classmethod
def load(cls, path: str, embedding_model=None):
Expand Down