Skip to content

Commit

Permalink
Corrected helper to use proper factory
Browse files Browse the repository at this point in the history
  • Loading branch information
LuomaJuha committed Sep 12, 2024
1 parent 9d2d9d8 commit 353c7cf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,10 @@ public function __invoke(
throw new \Exception('Unexpected options sent to factory.');
}
$dbServiceManager = $container->get(\VuFind\Db\Service\PluginManager::class);
$viewRenderer = $container->get('ViewRenderer');
$helper = new $requestedName(
$container->get('ViewRenderer')->plugin('record'),
$viewRenderer->plugin('record'),
$viewRenderer->plugin('recordImage'),
$dbServiceManager->get(CommentsServiceInterface::class)
);
$helper->registerExtensions($container);
Expand Down
2 changes: 1 addition & 1 deletion themes/finna2/theme.config.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
'Finna\View\Helper\Root\RecordImage' => 'Finna\View\Helper\Root\RecordImageFactory',
'Finna\View\Helper\Root\RecordLink' => 'Finna\View\Helper\Root\RecordLinkFactory',
'Finna\View\Helper\Root\RecordLinker' => 'Finna\View\Helper\Root\RecordLinkerFactory',
'Finna\View\Helper\Root\ResultFeed' => 'VuFind\View\Helper\Root\ResultFeedFactory',
'Finna\View\Helper\Root\ResultFeed' => 'Finna\View\Helper\Root\ResultFeedFactory',
'Finna\View\Helper\Root\ScriptSrc' => 'Finna\View\Helper\Root\HelperWithThemeInfoFactory',
'Finna\View\Helper\Root\Search' => 'Laminas\ServiceManager\Factory\InvokableFactory',
'Finna\View\Helper\Root\SearchBox' => 'VuFind\View\Helper\Root\SearchBoxFactory',
Expand Down

0 comments on commit 353c7cf

Please sign in to comment.