-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from vue2 + vue cli to vue3 + vitejs #199
Open
ZaynChen
wants to merge
19
commits into
Litarvan:master
Choose a base branch
from
ZaynChen:migrate2vue3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR upgrade project to Vue 3 + Vitejs.
Note
Dependencies changes
Changes
<script setup>
).settings
,backgroud
,color
are wrapped byref
andreactive
. They are global reactive now, and watchers are setup to automatically save the newsettings
,background
,color
to localstorage once their value changes, so we don't need to manually call localstorage to save them inSetup
,Theming
pages, just change their value, and let the watchers do the rest.new URL(imagepath, import.meta.url).href
to deal with static assets(images), so that vitejs can automatically resolve them and copy the corresponding assets todist
dir when build. Otherwise, the assets need to place under thepublic
dir. Note thatimport.meta.url
is module specific, so I've usinggetImageUrl
in some different files.createWebHashHistory()
(hash mode). If usingcreateWebHistory()
(html5 mode), thewebkit2gtk 2.40+
will raise theSecurityError
getLocal
now using thesettings.user.language
to producelang
, this fix wrong language detection whenlightdm.language
is a language name string.user.language
is a language code(zh_CN.UTF-8
on my archlinux), which comes fromlightdm.users
. But this may need more test to confirm(maybeuser.language
is only on my system)Test
I test it on my arch linux pc, and it just works, below is my machine environment.
Environment