Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form template for feature request #92

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

btlogy
Copy link
Contributor

@btlogy btlogy commented Dec 1, 2022

This PR is about LeastAuthority/it-ops#32 in which we want to collect feature request for Winden (and later Destiny).

The goal is to invite user (and team members) to express some use cases in the best possible way so we can process them efficiently.

I believe the best way to review this PR is to have a look at the test I've made here in a sandbox repository.

Then I guess we should discuss:

  • if this form is a good starting point and make it public asap or wait improvement first?
  • and state if this will cover the requirements expressed regarding the future of MW, or if we need some other place for that?

Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@btlogy
Copy link
Contributor Author

btlogy commented Dec 1, 2022

I'm pretty sure the broken build has nothing to do with my PR:

  ● <CodeInput /> › inputting a code with a typo on the second word › will say the second word is not recognized

    thrown: "Exceeded timeout of 5000 ms for a test.
    Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

      93 |
      94 |   describe("inputting a code with a typo on the second word", () => {
    > 95 |     it("will say the second word is not recognized", async () => {
         |     ^
      96 |       const user = userEvent.setup();
      97 |       render(
      98 |         <ThemeProvider>

      at src/app/components/CodeInput.test.tsx:95:5
      at src/app/components/CodeInput.test.tsx:94:3
      at Object.<anonymous> (src/app/components/CodeInput.test.tsx:15:1)

@btlogy btlogy mentioned this pull request Dec 2, 2022
@donpui
Copy link
Contributor

donpui commented Dec 5, 2022

I'm pretty sure the broken build has nothing to do with my PR:

  ● <CodeInput /> › inputting a code with a typo on the second word › will say the second word is not recognized

    thrown: "Exceeded timeout of 5000 ms for a test.
    Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

      93 |
      94 |   describe("inputting a code with a typo on the second word", () => {
    > 95 |     it("will say the second word is not recognized", async () => {
         |     ^
      96 |       const user = userEvent.setup();
      97 |       render(
      98 |         <ThemeProvider>

      at src/app/components/CodeInput.test.tsx:95:5
      at src/app/components/CodeInput.test.tsx:94:3
      at Object.<anonymous> (src/app/components/CodeInput.test.tsx:15:1)

Not related. We have an issue here: #94 and latest PR, which tried to improve situation: #87.

However we might need your help here to look on Github CI.

@btlogy
Copy link
Contributor Author

btlogy commented Dec 6, 2022

We better wait #101 to be merged into main so I can merge it back in this one and hopefully pass the checks.

@btlogy btlogy self-assigned this Dec 6, 2022
@btlogy btlogy mentioned this pull request Dec 8, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants