Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #171
This PR should fix the permissions which were occurring because
npm
runs asnode
user regardless if anything else in the container runs asroot
!The best option is to simply avoid the
root
as a best practice too.But using a specific
user
/uid
+group
/gid
usually requires some precautions as the currentuid
is not always1000
(e.g.: GitHub runner).The changes covers this with some
build-arg
which can be used to tune theuid
andgid
inside the image if needed (e.g.: GitHub workflows).This PR also proposes a way to install the node modules in the parent directory where the module resolution mechanism will lookup up if they are not found in the current one (if the image is run alone).
Although, the whole idea to
npm install
the modules twice for theclient
image (once inside and once outside), but only once for theclient-e2e
one (outside) is questionable and should be improved separately (see related issue).