Performance Testing #287

ldowen · 2024-07-17T20:57:54Z

Summary

This PR adds performance testing
It does the following:
- Updates the Caliper version
- Includes Adiak as a TPL
- Python wraps Adiak and Caliper calls
- Allows target export for ENABLE_DEV_BUILD builds
- Cleans up spack package file
- Adds a test for the Adiak and Caliper methods
- Adds documentation for using Caliper and Adiak
- Provides a default Caliper timer configuration and output filenames

ToDo :

Annotate RELEASE_NOTES.md with notable changes.
Create LLNLSpheral PR pointing at this branch. (PR#104)
LLNLSpheral PR has passed all tests.

…alize and finalize Adiak when modules are loaded or destroyed, added main timer around entire program, import Caliper using find_package, switched performance.ats with performance.py with atsExit routine, fixed build output bugs and quieted some output, changed caliper configuration to spot temporarily

…onfigmanager that is python wrapped and initialized in SpheralOptionsParser and uninitialized when module is unloaded

…or for adiak init

…ter function to get null pointer for adiak

…gh Caliper or the communicator), allow caliper_config to be turned off at runtime if necessary, moved the instance of TimerMgr into the functions to simplify the calls

… file

…ed config and filename caliper variables

…, added documentation, updated copyright for docs to 2024

…ult options since italics was too subtle

…ards to prevent overwriting caliper directory used for exporting

… and export LLNLSpheral when dev build is turned on

tests/unit/Utilities/testTimers.py.in

cmake/spheral/SpheralInstallPythonFiles.cmake

jmikeowen

Looking good to me once all the tests have passed

…ghwatermark spot configuration as it causes issues with LLNLSpheral tests

docs/developer/dev/diagnostic_tools.rst

Initial steps for adding performance testing

91ceccf

ldowen requested review from jmikeowen and mdavis36 July 17, 2024 20:57

ldowen self-assigned this Jul 17, 2024

ldowen marked this pull request as draft July 17, 2024 20:58

ldowen added 25 commits July 18, 2024 10:54

Start integrating Adiak

9c51f73

Merge branch 'develop' into feature/add_performance_testing

286985e

Added adiak_value functions and updated caliper.config

6dcc396

Merge branch 'develop' into feature/add_performance_testing

9f64517

Merge with develop

e365424

Merge branch 'develop' into feature/add_performance_testing

5b5ad91

Updated optparse to argparse, added singleton wrapp for the caliper c…

5acd124

…onfigmanager that is python wrapped and initialized in SpheralOptionsParser and uninitialized when module is unloaded

Merge branch 'develop' into feature/add_performance_testing

b321563

Fixed bugs with TimerMgr singleton

60c61cd

Merge branch 'develop' into feature/add_performance_testing

6e42bbe

Added valgrind python suppression, removed & for accessing communicat…

cd3f889

…or for adiak init

Fixed inconsistency in Communicator for non-MPI builds and added poin…

6b6628c

…ter function to get null pointer for adiak

Moved MPI finalize to occur when SpheralUtilities exits (either throu…

d488e50

…gh Caliper or the communicator), allow caliper_config to be turned off at runtime if necessary, moved the instance of TimerMgr into the functions to simplify the calls

Verify MPI finalize error inside communicator routine

229459e

Moved ifdefs in Communicator.hh

5a82358

Forgot to include DBC.hh

03503b6

Added more checks for mpi finalize, moved communicator routines to cc…

da9539e

… file

Added timer test script and changed CMake logic for making tests, add…

92e9706

…ed config and filename caliper variables

Added warning for caliper configurations provided to incorrect builds…

5b46839

…, added documentation, updated copyright for docs to 2024

Fix bug with getting caliperreader from TPL

c010fb7

Fixed timer test to accomodate issue with caliperreader

b4a6e92

Merge branch 'develop' into feature/add_performance_testing

b57bfd9

Merge branch 'develop' into feature/add_performance_testing

d1bb75d

Added more default adiak values

cf674cd

ldowen added 6 commits September 5, 2024 11:17

Prevent automatically adding file extensions to caliper file names

4c21cbd

Added caliper and adiak to TPL list, changed italics to bold for defa…

209ffa5

…ult options since italics was too subtle

Documentation changes

77270fc

Fixed dev build exporting, improved exporting of find_package TPLs

5c32362

Changed axom to be shared by default

3e45c23

Merge branch 'develop' into feature/add_performance_testing

92a7295

ldowen marked this pull request as ready for review September 10, 2024 23:31

ldowen added 6 commits September 10, 2024 16:32

Update Release notes

17d78ee

Changing axom back to static to see if that fixes the tests

60f864e

Fix bug where ENABLE_SHARED was ignored, added guards for TPL exporting

29a11f1

Making axom always shared

a133ba3

Switched back to using axom~shared+cuda or axom+shared~cuda, added gu…

53e3eb0

…ards to prevent overwriting caliper directory used for exporting

Remove unnecessary export config lines, add logic to properly compile…

7ba9dbd

… and export LLNLSpheral when dev build is turned on

mdavis36 reviewed Sep 17, 2024

View reviewed changes

tests/unit/Utilities/testTimers.py.in Outdated Show resolved Hide resolved

jmikeowen reviewed Sep 17, 2024

View reviewed changes

cmake/spheral/SpheralInstallPythonFiles.cmake Outdated Show resolved Hide resolved

jmikeowen previously approved these changes Sep 17, 2024

View reviewed changes

Remove unused cmake variables for timer tests

d1b9f5a

ldowen dismissed jmikeowen’s stale review via d1b9f5a September 18, 2024 21:12

Stop allowing blue os test to fail in CI

3279a71

mdavis36 previously approved these changes Sep 19, 2024

View reviewed changes

Added ability to specify a caliper configuration json file, remove hi…

bbc1706

…ghwatermark spot configuration as it causes issues with LLNLSpheral tests

ldowen dismissed mdavis36’s stale review via bbc1706 September 19, 2024 23:29

jmikeowen reviewed Sep 24, 2024

View reviewed changes

docs/developer/dev/diagnostic_tools.rst Outdated Show resolved Hide resolved

ldowen added 3 commits September 25, 2024 10:20

Updated Caliper diagnostic documentation

6c93ae5

Fix documentation bug

db8dd97

More document fixes

a249a09

mdavis36 approved these changes Sep 26, 2024

View reviewed changes

jmikeowen approved these changes Sep 26, 2024

View reviewed changes

ldowen merged commit 94bc035 into develop Sep 26, 2024
2 checks passed

ldowen deleted the feature/add_performance_testing branch September 26, 2024 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Performance Testing #287

Performance Testing #287

ldowen commented Jul 17, 2024 •

edited

Loading

jmikeowen left a comment

Performance Testing #287

Performance Testing #287

Conversation

ldowen commented Jul 17, 2024 • edited Loading

Summary

ToDo :

jmikeowen left a comment

Choose a reason for hiding this comment

ldowen commented Jul 17, 2024 •

edited

Loading