Skip to content

Commit

Permalink
Merge pull request #290 from LLNL/feature/remove_race_warnings
Browse files Browse the repository at this point in the history
Remove asserts that cause false positive race warnings.

Due to a bug in GCC, we cannot write a clean macro to prevent ThreadSanitizer from checking false positive code. Decided to remove the asserts.
  • Loading branch information
KIwabuchi authored Sep 23, 2023
2 parents 80e9976 + 2a7f29c commit b79772d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions include/metall/kernel/manager_kernel_impl.ipp
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ void *manager_kernel<chnk_no, chnk_sz>::allocate(
return nullptr;
}
assert(offset >= 0);
assert(offset + nbytes <= m_segment_storage.size());

return priv_to_address(offset);
}

Expand All @@ -114,7 +114,6 @@ void *manager_kernel<chnk_no, chnk_sz>::allocate_aligned(
return nullptr;
}
assert(offset >= 0);
assert(offset + nbytes <= m_segment_storage.size());

auto *addr = priv_to_address(offset);
assert((uint64_t)addr % alignment == 0);
Expand Down

0 comments on commit b79772d

Please sign in to comment.